[Validator] add checkTldDns option to UrlValidator
#46921
Conversation
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
|
Hey! I think @WojciechKania3 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
Checking the DNS is out of the scope for UrlValidator (which validates the syntax). In any case, we used to have this feature and it was deprecated (#25516) and removed (#31681) a while ago. |
@fabpot just wondering, what is UrlValidator good for at this moment, since it validates basically any string as a valid url as mentioned in #39986 which is now closed. |
With Symfony 5.0 the option "checkDns" was removed from the "UrlValidator" and the validator was completely changed to RegEx checks.
See: https://symfony.com/doc/4.4/reference/constraints/Url.html#checkdns
In issue #39986 it was noted that there is no way to check if this checked URL would really be usable.
While I can understand that individual DNS records might be temporarily unavailable, TLD name servers should generally always be available.
For this reason, I added the new option "checkTldDns" in this MR based on the option from Symfony 4.4 and earlier. This will perform a NS DNS query to the TLD of the checked URL.
Of course, this is still not an absolutely secure method but optionally allows to increase the security of the check.
If there is a chance that this will be added, I will be happy to write the doc for it as well.