[Serializer] Ignore getter with required parameters (Fix #46592) #46958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
dunglas
approved these changes
Jul 17, 2022
fabpot
requested changes
Jul 17, 2022
src/Symfony/Component/Serializer/Tests/Fixtures/Annotations/IgnoreDummyAdditionalGetter.php
Outdated
Show resolved
Hide resolved
mtarld
approved these changes
Jul 18, 2022
fabpot
approved these changes
Jul 19, 2022
|
Thank you @astepin. |
| @@ -100,6 +100,11 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata) | |||
| continue; | |||
| } | |||
|
|
|||
| $getAccessor = preg_match('/^(get|)(.+)$/i', $method->name); | |||
There was a problem hiding this comment.
This regex looks "fishy": ignoring capturing groups (as matches are not used), it's equivalent to /^(get)?.+$/i i.e. just /^.+$/ i.e. will match any method (not only getters)
There was a problem hiding this comment.
I've filed #47255 to fix this.
There was a problem hiding this comment.
I missed that. A copy paste error. Thanks @jsor for fixing
Merged
fabpot
added a commit
that referenced
this pull request
Aug 12, 2022
…sor) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Serializer] Fix get accessor regex in AnnotationLoader The pipe in the regex makes it match *all* methods. | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a This fixes a bug introduced in #46958. It was also discovered in the PR but after it got merged. See #46958 (comment). Commits ------- 1132171 [Serializer] Fix get accessor regex in AnnotationLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no Ignore annotation is used, the attributes for serialization are obtained using
Symfony\Component\Serializer\Normalizer\ObjectNormalizer::extractAttributes.There it is checked if the method has required parameters and if yes, the method is ignored.
However, if you use the Ignore annotation, the attributes are determined with a different method. Here I have adapted at least for get methods the behavior as it was before.
If someone serialized a class with Ignore annotations before, he got here
\Symfony\Component\PropertyAccess\PropertyAccessor::readPropertyan exception as written in ticket #46592. With this fix the methods are ignored and there is no exception anymore.