Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve some PHPdocs based on existing Symfony stubs in PHPstan and Psalm #47016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 3 commits into from
Aug 2, 2022
+108 −44
Merged

Improve some PHPdocs based on existing Symfony stubs in PHPstan and Psalm #47016

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38ab6de
Improve some PHPdocs based on existing Symfony stubs in PHPstan and P…
Apr 12, 2021
fa7703b
[ErrorHandler] Do not patch return types that are not a valid PHP type
wouterj Jul 21, 2022
f5a802a
[DependencyInjection] Add nice exception when using non-scalar parame…
wouterj Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[ErrorHandler] Do not patch return types that are not a valid PHP type
  • Loading branch information
@wouterj
wouterj committed Jul 28, 2022
commit fa7703ba4a70c53c1565217ca91483f1db947edb
5 changes: 5 additions & 0 deletions src/Symfony/Component/ErrorHandler/DebugClassLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,11 @@ private function setReturnType(string $types, string $class, string $method, str
return;
}

if (!preg_match('/^(?:\\\\?[a-zA-Z_\x80-\xff][a-zA-Z0-9_\x80-\xff]*)+$/', $n)) {
// exclude any invalid PHP class name (e.g. `Cookie::SAMESITE_*`)
continue;
}

if (!isset($phpTypes[''])) {
$phpTypes[] = $n;
}
Expand Down