[Mailer] Add new events #47080
Merged
[Mailer] Add new events #47080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2022
OskarStark
reviewed
Jul 29, 2022
| { | ||
| public function __construct( | ||
| private RawMessage $message, | ||
| private \Throwable $error, |
There was a problem hiding this comment.
Why not public and no getter ?
For further potential BC handling?
There was a problem hiding this comment.
I don't get it, there is a getError() method here 😕
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 3, 2025
…geEvent` (wkania) This PR was merged into the 6.4 branch. Discussion ---------- [Mailer] Mention the `SentMessageEvent` and `FailedMessageEvent` The symfony/symfony#47080 PR was created to solve the problem of [debugging](symfony/symfony#37570) and to get [information](symfony/symfony#42108) about email after it was sent. The section about [debugging](https://symfony.com/doc/current/mailer.html#debugging-emails) does not mention those events. Added some links for better navigation. For example what debug returns: ``` < 220 ESMTP SYMFONY.COM > EHLO [127.0.0.1] < 250-smtp.symfony.com < 250-PIPELINING < 250-SIZE 157286400 < 250-AUTH PLAIN LOGIN PLAIN LOGIN PLAIN LOGIN < 250-AUTH=PLAIN LOGIN PLAIN LOGIN PLAIN LOGIN < 250-ENHANCEDSTATUSCODES < 250-8BITMIME < 250 SMTPUTF8 > AUTH LOGIN < 334 VXNlcm5hbWU6 > ZXhhbXBsZUBzeW1mb255LmNvbQ== < 334 UGFzc3dvcmQ6 > U3ltcGhvbnkg.aXMgQXdlc29tZQ== < 235 2.7.0 Authentication successful > MAIL FROM:<[email protected]> < 250 2.1.0 Ok > RCPT TO:<[email protected]> < 250 2.1.5 Ok > DATA < 354 End data with <CR><LF>.<CR><LF> > . < 250 OK. ID: a20fb6ebbc54d22b ``` P.S. I see that the checks now can find repeated words: ``` mailer.rst ✘ 1765: The word "the" is used more times in a row. -> ``FailedMessageEvent`` allows acting on the the initial message in case of a failure and some ``` Commits ------- 8e3c1db [Mailer] Mention the SentMessageEvent and FailedMessageEvent in the debug section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatching 2 new events:
SentMessageEventandFailedMessageEventwhen sending an email.It allows acting on the
SentMessageor the "initial" message in case of a failure.