-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DependencyInjection] Allow service subscribers to return SubscribedService[]
#47101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServiceSubscriberInterface::getSubscribedServices()
to return SubscribedService[]
ServiceSubscriberInterface::getSubscribedServices()
to return SubscribedService[]
kbond
commented
Jul 28, 2022
ServiceSubscriberInterface::getSubscribedServices()
to return SubscribedService[]
SubscribedService[]
dfdeb74
to
263acdd
Compare
I like it :) Let's see how DI can leverage that for Autowiring now. |
11073d1
to
29ab4b0
Compare
29ab4b0
to
0fb543f
Compare
kbond
commented
Aug 16, 2022
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Aug 16, 2022
src/Symfony/Component/DependencyInjection/Compiler/RegisterServiceSubscribersPass.php
Outdated
Show resolved
Hide resolved
25882d6
to
aa868d8
Compare
kbond
commented
Aug 16, 2022
kbond
commented
Aug 16, 2022
aa868d8
to
c90f7f3
Compare
SubscribedService[]
SubscribedService[]
d921b76
to
2babe71
Compare
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/RegisterServiceSubscribersPass.php
Outdated
Show resolved
Hide resolved
2babe71
to
8ed139e
Compare
6a125e3
to
7785a60
Compare
nicolas-grekas
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(I made some changes, see 2nd commit)
7785a60
to
049f15e
Compare
Thank you @kbond. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
ServiceSubscriberInterface::getSubscribedServices()
to returnSubscribedService[]
which now has the ability to add DI attribute objects (ieTarget
).When using the
ServiceSubscriberTrait
, theSubscribedService
attribute can add attributes as well:TODO: