[Mailer] Add a way to change the Bus transport dynamically #47190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be refactored to use #47191 when/id merged. |
fabpot
added a commit
that referenced
this pull request
Aug 5, 2022
…ail via Messenger (fabpot) This PR was merged into the 6.2 branch. Discussion ---------- [Mailer] Add a way to inject Stamps when sending an email via Messenger | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | In #47190, we add a way to add a specific stamp to the message sent to the Messenger bus. I think we should make this possibility more generic. Commits ------- 77381fa [Mailer] Add a way to inject Stamps when sending an email via Messenger
bcb47cc to
62af777
Compare
|
Rebased and implementation updated. Ready for review. |
46a009a to
3f0a8de
Compare
src/Symfony/Component/Mailer/EventListener/MessengerTransportListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/EventListener/MessengerTransportListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/EventListener/MessengerTransportListener.php
Outdated
Show resolved
Hide resolved
3f0a8de to
8f47f14
Compare
|
Comments fixed. |
nicolas-grekas
approved these changes
Aug 7, 2022
chalasr
approved these changes
Aug 7, 2022
8f47f14 to
ffe3600
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on #39306. Once merged, this PR will be rebased.
This allows overriding the bus transport "dynamically" via the
X-Bus-Transportheader.