Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change incorrect message, when the sender in the global envelope or the from header of asEmailMessage() is not defined. #47342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2023
Merged

Change incorrect message, when the sender in the global envelope or the from header of asEmailMessage() is not defined. #47342

merged 1 commit into from
Oct 1, 2023

Conversation

fredericlesueurs
Copy link
Contributor

See issue: #47313

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix 47313
License MIT
Doc PR no

Correction of an error message containing a syntax structure error.
See issue: #47313

@carsonbot carsonbot added this to the 6.2 milestone Aug 19, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fredericlesueurs fredericlesueurs changed the title Fixed incorrect message, when the sender in the global envelope or the from header of asEmailMessage() is not defined. Change incorrect message, when the sender in the global envelope or the from header of asEmailMessage() is not defined. Aug 19, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 5, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@fabpot fabpot modified the milestones: 6.4, 5.4 Oct 1, 2023
@fredericlesueurs @fabpot
Change incorrect message, when the sender in the global envelope or t…
5d9d6b7 
…he from header of asEmailMessage() is not defined.
@fabpot fabpot changed the base branch from 6.4 to 5.4 October 1, 2023 07:26
@fabpot fabpot force-pushed the feature/fix-incorect-message-error-in-email-channel branch from 3e401cd to 5d9d6b7 Compare October 1, 2023 07:26
@fabpot
Copy link
Member

fabpot commented Oct 1, 2023

Thank you @fredericlesueurs.

@fabpot fabpot merged commit 2e11577 into symfony:5.4 Oct 1, 2023
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
@fabpot fabpot mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fredericlesueurs @carsonbot @fabpot @nicolas-grekas