-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DependencyInjection] Handle INI arrays #47367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MatTheCat
commented
Aug 23, 2022
Q | A |
---|---|
Branch? | 4.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #47357 |
License | MIT |
Doc PR | N/A |
Looks like a new feature to me. |
In what way? It's fixing a regression in 3.2.0. |
It's not supported today, so that's a new feature. |
Strange perspective, not throwing a TypeError on valid input is a feature? |
But then, everything is a bug fix. |
I don't understand the point you're trying to make, there's a great scope between fixing a thrown |
But it was at some point 🤔 I don't know how Symfony handles regressions though (Wikipedia says regressions are bugs). |
Symfony 3.2 EOLed was 5 years ago. Nobody reported this since then. So, that's a new feature. |
Thank you @MatTheCat. |
For PHP 7.x, this only became a TypeError in 4.4, before that it was only a PHP warning. Btw, this "nobody" reported it while trying to upgrade a legacy app. |