Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Handle INI arrays #47367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47357
License MIT
Doc PR N/A

@fabpot
Copy link
Member

fabpot commented Aug 23, 2022

Looks like a new feature to me.

@lpd-au
Copy link

lpd-au commented Aug 23, 2022

Looks like a new feature to me.

In what way? It's fixing a regression in 3.2.0.

@fabpot
Copy link
Member

fabpot commented Aug 23, 2022

It's not supported today, so that's a new feature.

@fabpot fabpot modified the milestones: 4.4, 6.2 Aug 23, 2022
@lpd-au
Copy link

lpd-au commented Aug 23, 2022

Strange perspective, not throwing a TypeError on valid input is a feature?

@fabpot
Copy link
Member

fabpot commented Aug 23, 2022

Strange perspective, not throwing a TypeError on valid input is a feature?

But then, everything is a bug fix.
Anyway, we favor stability over everything else in our maintained branches, so we're very strict in what we consider a bug.

@lpd-au
Copy link

lpd-au commented Aug 23, 2022

But then, everything is a bug fix.
Anyway, we favor stability over everything else in our maintained branches, so we're very strict in what we consider a bug.

I don't understand the point you're trying to make, there's a great scope between fixing a thrown Error and adding new functionality. Nonetheless, this should have little to no backwards compatibility impact; if your code was working beforehand, it'll still work now.

@MatTheCat
Copy link
Contributor Author

MatTheCat commented Aug 23, 2022

It's not supported today, so that's a new feature.

But it was at some point 🤔 I don't know how Symfony handles regressions though (Wikipedia says regressions are bugs).

@fabpot
Copy link
Member

fabpot commented Aug 26, 2022

Symfony 3.2 EOLed was 5 years ago. Nobody reported this since then. So, that's a new feature.
As I said, we have a very strict definition of what is considered a new feature vs a bug.

@fabpot fabpot changed the base branch from 4.4 to 6.2 August 26, 2022 08:55
@fabpot fabpot requested a review from dunglas as a code owner August 26, 2022 08:55
@fabpot
Copy link
Member

fabpot commented Aug 26, 2022

Thank you @MatTheCat.

@fabpot fabpot merged commit a0e0325 into symfony:6.2 Aug 26, 2022
@MatTheCat MatTheCat deleted the ticket_47357 branch August 26, 2022 08:59
@lpd-au
Copy link

lpd-au commented Aug 26, 2022

Symfony 3.2 EOLed was 5 years ago. Nobody reported this since then. So, that's a new feature. As I said, we have a very strict definition of what is considered a new feature vs a bug.

For PHP 7.x, this only became a TypeError in 4.4, before that it was only a PHP warning. Btw, this "nobody" reported it while trying to upgrade a legacy app.

@fabpot fabpot mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IniFileLoader throws when parsing arrays
4 participants