Can you add a test case that breaks before your patch?

@chalasr done.

While updating testRequestAttributeLocaleNotOverridenFromAcceptLanguageHeader I stumbled into a weird behavior which I think was caused by the Accept-Language header set the wrong way, so I updated tests doing this.

@MatTheCat Can you create a PR on 4.4 for the tests fix?

@fabpot see #47638 (concerned tests were added by #43108 on 5.4). Should I copy its changes on this PR? Else tests will fail until it is merged and rebased 🤔

Looks like because #47638's description included "Fix #47377(some comment)", github closed this PR automatically when merging #47638.

Should I copy its changes on this PR? Else tests will fail until it is merged and rebased 🤔

Rebase unlocked, #47638 has been merged up to 6.2.

Damn okay sorry 😅

PR rebased!

No worries, I'd say it should be improved on Github :)
Can you please add a small entry in the framework-bundle CHANGELOG?

Set locale from request rather that default locale if "framework.enabled_locales" is empty and "framework.set_locale_from_accept_language" is true

WDYT? Don’t really know how to make it shorter.

Works for me!

Thank you @MatTheCat.

I'm a bit late here but this means we are going to always send the Vary: Accept-Language header, isn't it? I'm not sure this is legit.

@nicolas-grekas only if set_locale_from_accept_language is true and the Accept-Language header contains some locales.

Oh, thanks. Two other issues: why on 6.2 and not on 6.1? And more importantly: the vary header should also be sent when $preferredLanguage is falsy. The code should look like this:

        } elseif ($this->useAcceptLanguageHeader) {
            if ($preferredLanguage = $request->getPreferredLanguage($this->enabledLocales)) {
                $request->setLocale($preferredLanguage);
            }
            $request->attributes->set('_vary_by_language', true);
        }

Can you please send a PR on 6.1 if you agree?

I’m not sure about you two questions 😞 so I’ll wait for the approval of other members before submitting another PR.

Nicolas is right, please go ahead if you want/can.