[Mailer] Fix edge cases in STMP transports #47403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Aug 27, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #47402 |
| License | MIT |
| Doc PR | n/a |
5e8e82b to
a570e63
Compare
sbuerk
approved these changes
Aug 27, 2022
There was a problem hiding this comment.
I have basicly used the fix for SmtpTransport in our Branch using v5.4.12 and v6.1.4 and the deprecation message is gone.
However, the change for EsmtpTransport I do not really get (as I'm not that into the code) and comparing with the version we use I had no clue how to "adopt" them. We do not have a test for them either .... but I think it may be okay.
This was referenced Sep 30, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.