Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] Regression when ArgumentResolver::getArguments() passes an empty array of reflectors to ArgumentMetadataFactory::createArgumentMetadata() #47461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[HttpKernel] Regression when ArgumentResolver::getArguments() passes an empty array of reflectors to ArgumentMetadataFactory::createArgumentMetadata() #47461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c377a99
Restore support for arguments as arrays.
Sep 2, 2022
3aff616
Revert "Restore support for arguments as arrays."
Sep 2, 2022
9aa1815
Don't send reflectors if there aren't any, not even an empty array.
Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpKernel/Controller/ArgumentResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function __construct(ArgumentMetadataFactoryInterface $argumentMetadataFa
public function getArguments(Request $request, callable $controller): array
{
$arguments = [];
$reflectors = $request->attributes->get('_controller_reflectors') ?? [];
$reflectors = $request->attributes->get('_controller_reflectors') ?? NULL;

foreach ($this->argumentMetadataFactory->createArgumentMetadata($controller, ...$reflectors) as $metadata) {
foreach ($this->argumentValueResolvers as $resolver) {
Expand Down