[Mime] Simplify adding Parts to an Email #47462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @alamirault has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
alamirault
suggested changes
Sep 4, 2022
54fa06b to
07a54d2
Compare
07a54d2 to
83476e3
Compare
8a4b63b to
0811e87
Compare
0811e87 to
4843df3
Compare
4843df3 to
0a29d97
Compare
nicolas-grekas
approved these changes
Sep 28, 2022
This was referenced Sep 28, 2022
fabpot
added a commit
that referenced
this pull request
Oct 15, 2022
…l::addPart() (fabpot) This PR was merged into the 6.2 branch. Discussion ---------- [Mime] deprecate attach/embed methods in favor of Email::addPart() | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | - #47462 follow-up Commits ------- 7cdbd20 [Mime] deprecate attach/embed methods in favor of Email::addPart()
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Oct 20, 2022
…hiddewie) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- Use `addPart` instead of `embed*` or `attach*`. Fixes symfony#17303 Ref symfony#17353 Ref symfony/symfony#47711 Ref symfony/symfony#47462 This PR contains the documentation for simplifications for adding parts to `Email`s. Commits ------- ebbffc5 Use `addPart` instead of `embed*` or `attach*`.
Merged
This was referenced Aug 25, 2023
fabpot
added a commit
that referenced
this pull request
Sep 29, 2023
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Mime] Fix email (de)serialization issues | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47991 | License | MIT | Doc PR | - #48156 fixed #47991 while introducing a big breaking change (the `File` lazy load feature is broken and that was the whole point of that class when it was introduced in #47462 as that feature existed even prior to that PR) on a minor Symfony version (updating from 6.1 to 6.2 broke our application). More context can be found here: #48156 (comment) This PR aims to revert back the `attachFromPath` behavior to what it was before #48156 while still fixing the deserialization issue reported in #47991 The first commit fixes the serialization logic to work the same way it had worked on both 5.4 and 6.1 (which means we are reverting #48156), while the second commit fixes the deserialization issue reported in #47991. I've also added tests to prevent serialization/deserialization regressions in the future. Commits ------- 32836b9 [Mime] Fix email (de)serialization issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing some MIME bugs, I realized we have a substantial cyclomatic complexity due to the attach/attachFromPath/embed/embedFromPath/attachPart methods on the Email class.
This PR simplifies all of that and introduces a way to have a file for TextPart as well (via the new
file://notation) and it keeps the lazy-loading feature which was why those methods were introduced in the first place.From now, I've kept all the methods, but I'm wondering if we should deprecate all of them and only keep
attachPart()(which I would like to renameaddPart()).