Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Uid] Add MaxUuid and MaxUlid #47515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

[Uid] Add MaxUuid and MaxUlid #47515

merged 1 commit into from
Sep 9, 2022

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

As described for UUIDs in https://datatracker.ietf.org/doc/draft-peabody-dispatch-new-uuid-format/

@carsonbot carsonbot added this to the 6.2 milestone Sep 7, 2022
@nicolas-grekas nicolas-grekas force-pushed the uid-max branch 5 times, most recently from a491c12 to 6de363e Compare September 8, 2022 09:39
@carsonbot
Copy link

Hey!

I think @shrikeh has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas mentioned this pull request Sep 8, 2022
Merged
stof
stof approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the use case for the max uuid. But as it is part of the spec, I'm fine with adding it.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Sep 9, 2022 •
edited
Loading

I don't really understand the use case for the max uuid. But as it is part of the spec, I'm fine with adding it.

I don't have one either, but for completeness with the spec yes. Having it available might enable some use cases we'll know about one day :)

@nicolas-grekas nicolas-grekas merged commit c991df6 into symfony:6.2 Sep 9, 2022
@nicolas-grekas nicolas-grekas deleted the uid-max branch September 9, 2022 08:21
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@fancyweb fancyweb Awaiting requested review from fancyweb

Assignees
No one assigned
Labels
Status: Reviewed Uid
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @carsonbot @stof