[FrameworkBundle] Fix passing serializer.default_context option to normalizers
#47637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #47012 |
HeahDude
reviewed
Sep 27, 2022
ObjectNormalizer that doesn't use default_context config optionserializer.default_context option to normalizers
4a39eb4 to
db6ab74
Compare
chalasr
approved these changes
Sep 28, 2022
| @@ -6,9 +6,16 @@ framework: | |||
| enabled: true | |||
| default_context: | |||
| enable_max_depth: true | |||
| # The option below is used in \Symfony\Bundle\FrameworkBundle\Tests\Functional\SerializerTest::testObjectNormalizerUsesDefaultContextConfigOption | |||
| # to assert that the `default_context` is taken into account in serializers | |||
There was a problem hiding this comment.
The test itself should be enough to spot any issue quickly so I'm not sure this is useful
There was a problem hiding this comment.
You're right.
Maybe do I need to change the test to take into account the other normalizers that have the same behavior with $defaultContext since @nicolas-grekas has fixed them too?
There was a problem hiding this comment.
that'd be nice if you can yes !
There was a problem hiding this comment.
Done.
I changed the tests to target all normalizers and encoders that are tagged serializer.normalizer or serializer.encoder and that have the argument $defautContext in their constructor, the same as what SerializerPass does.
db6ab74 to
6ac8f52
Compare
serializer.default_context option to normalizersserializer.default_context option to normalizers and encoders
serializer.default_context option to normalizers and encodersserializer.default_context option to normalizers
6ac8f52 to
d863692
Compare
|
Thank you @wuchen90. |
This was referenced Sep 30, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default_contextconfig option underserializerof FrameworkBundle isn't taken into account when usingSymfony\Component\Serializer\Normalizer\ObjectNormalizer.Maybe it's the case for other serializers but let's fix one at a time.