[FrameworkBundle] Filter out trans paths that are covered by a parent folder path #47695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
Outdated
Show resolved
Hide resolved
12b311d to
bfb8cbe
Compare
5499355 to
3fdcbca
Compare
|
Thank you @natewiebe13. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 28, 2022
…by a parent folder path (natewiebe13) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Filter out trans paths that are covered by a parent folder path | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Partially Fixes #45645 | License | MIT | Doc PR | N/A It was possible to end up with duplicated paths which would could result in many files being scanned more than once. This prevents that. Commits ------- 459ac04 [FrameworkBundle] Filter out trans paths that are covered by a parent folder path
3fdcbca to
459ac04
Compare
This was referenced Sep 30, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to end up with duplicated paths which would could result in many files being scanned more than once. This prevents that.