Guard scripts from being run in non-CLI contexts #47777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd32ef7 to
edaea64
Compare
stof
approved these changes
Oct 3, 2022
xabbuh
approved these changes
Oct 3, 2022
OskarStark
approved these changes
Oct 3, 2022
fabpot
approved these changes
Oct 4, 2022
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 4, 2022
…s-grekas) This PR was merged into the 5.4 branch. Discussion ---------- Guard scripts from being run in non-CLI contexts | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Same as #47777 but for 5.4. I checked 6.x and we didn't add more scripts there. Commits ------- 9335c81 Guard scripts from being run in non-CLI contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although exposing those scripts on the web would be a mistake, let's disallow running them but from the CLI.