[DependencyInjection] Allow array for the value of Autowire attribute #47801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 17, 2022
fabpot
approved these changes
Oct 18, 2022
|
Thank you @willemverspyck. |
stof
reviewed
Oct 18, 2022
| string $service = null, | ||
| string $expression = null, | ||
| ) { | ||
| if (!($service xor $expression xor null !== $value)) { | ||
| throw new LogicException('#[Autowire] attribute must declare exactly one of $service, $expression, or $value.'); | ||
| } | ||
|
|
||
| if (null !== $value && str_starts_with($value, '@')) { | ||
| if (\is_string($value) && str_starts_with($value, '@')) { |
There was a problem hiding this comment.
For an array, wouldn't this need to process the strings inside that array to convert their prefixes too ?
There was a problem hiding this comment.
I don't think we want to allow nesting services into arrays.
There was a problem hiding this comment.
We do allow that in Yaml or XML (which is how you passed an array of objects indexed by some keys for instance)
|
Thanks for reviewing @fabpot and @nicolas-grekas 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Symfony 6.1 it's possible to use #[Autowire] for the service autowiring logic. Array as autowire parameters is not supported yet. In YAML or the attribute Autoconfigure it worked.
#[Autoconfigure(bind: [ '$parameters' => [ 'PARAMETER_DAY_START' => '%env(string:PARAMETER_DAY_START)%', 'PARAMETER_DAY_END' => '%env(string:PARAMETER_DAY_END)%', 'FILTER_LIMIT' => '%env(int:FILTER_LIMIT)%', 'FILTER_OFFSET' => '%env(int:FILTER_OFFSET)%', ], ])] class WidgetService { public function __construct(private readonly array $parameters) { } }After this PR there is support for an array (including some extra tests):