[Security] TraceableAccessDecisionManager: fix inspecting voters of custom access decision managers #47817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
requested changes
Oct 10, 2022
src/Symfony/Component/Security/Core/Authorization/TraceableAccessDecisionManager.php
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Oct 10, 2022
I couldn't decide initially if it should be suggested as a bug or feature, but it looks more like an improvement. Do you think I should create another PR for 6.2 too? I think it has been said that merges to older tags would be merged to newer ones in a few days. |
|
No worry, we can switch the branch while merging this PR. |
…ustom access decision managers
|
Thank you @sarbanha. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the "if" statement that verifies if the ADM is instance of AccessDecisionManager.
This control breaks profiler when it is trying to browse "Security" tab while a custom ADM was developed. The reason is that the "if" statement prevents SecurityDataCollector.php to retrieve the strategy and the list of voters.
Based on my tests this modification doesn't affect the regular functionality of security-core.