[Filesystem] rename Filesystem::mirror() option copy_on_windows to follow_symlinks
#47969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Build failures seem to be unrelated to the change. |
Filesystem::mirror() option copy_on_windows to follow_symlinks
|
Hey! I think @gechetspr has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
gechetspr
approved these changes
Oct 31, 2022
Contributor
gechetspr
left a comment
There was a problem hiding this comment.
Looks good from my side. One minor comment is IMO nice to have, but it's working fine as it is
0cf3c4d to
45e3f7f
Compare
gechetspr
approved these changes
Nov 1, 2022
45e3f7f to
f07cee8
Compare
OskarStark
reviewed
Jan 20, 2023
f07cee8 to
df5c99f
Compare
be1d2e2 to
ffb9ae5
Compare
OskarStark
reviewed
Jun 5, 2023
OskarStark
reviewed
Jun 5, 2023
4b3f98e to
fdcc518
Compare
Filesystem::mirror() option copy_on_windows to follow_symlinksFilesystem::mirror() option copy_on_windows to follow_symlinks
mtarld
requested changes
Oct 29, 2024
…o `follow_symlinks`
fdcc518 to
ee97214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for #25798. In the issue is described, that the option copy_on_windows is a bit misleading, because there might be as well other usecases to follow the symlinks like copying to a different drive or a docker context which does not support symlinks.
The old option
copy_on_windowsis marked as deprecated with the hint to use the optionfollow_symlinks, doing interally exactly the same. Just a renaming of the option with making the old one deprecated for no BC breaks.