[Mailer] Include all transports' debug messages in RoundRobin transport exception #48126
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
The failing CI build is not related to the changes in this PR (another module) and passes locally. Not sure if the test is flaky. |
7ddfd21 to
cd43856
Compare
|
Thank you @mixdf. |
|
@nicolas-grekas Thanks for merging this change 🙂 |
Description
The RoundRobin Mail transport does not include inner transports' debug messages in case of failure, which makes it very difficult to reason about the failures.
This PR attempts to add that debug information to the thrown TransportException.
In the process of fixing this issue, I discovered that one of the existing tests is incorrect. The last assertion is never executed and the test passes regardless of the assertion state. The test was also fixed.
Note that although this issue exists in https://github.com/symfony/symfony/tree/5.0, I wasn't able to apply the same patch to it since the behavior of the transport (specifically the cursor property) was different. I can open a new PR to fix the same issue for that branch as well.