[Yaml] Add flag to dump numeric key as string #48127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3". Cheers! Carsonbot |
maxbeckers
reviewed
Nov 7, 2022
derrabus
requested changes
Nov 7, 2022
There was a problem hiding this comment.
Thank you for your contribution. At first glance, the implementation looks a bit too simple, but I might be mistaken. My main concern is the very poor test coverage for this new feature. Introducing a new flag adds complexity and possible side effects. We should especially make sure that the flag plays nicely when being combined with other flags that affect array structures or type casting of any sort.
nicolas-grekas
added a commit
that referenced
this pull request
Nov 9, 2022
…rault) This PR was merged into the 6.2 branch. Discussion ---------- [Yaml] Extract duplicate code to private function | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> I saw the same code/logic was duplicated in `Inline` class while working on #48127. This little patch can avoid bug/inconsistency Commits ------- 6026422 [Yaml] Extract duplicate code to private function
377c613 to
27618ce
Compare
maxbeckers
reviewed
Nov 12, 2022
derrabus
requested changes
Nov 13, 2022
derrabus
requested changes
Dec 9, 2022
7da5d08 to
8be79bb
Compare
derrabus
approved these changes
Dec 11, 2022
javiereguiluz
approved these changes
Dec 15, 2022
xabbuh
requested changes
Dec 17, 2022
xabbuh
approved these changes
Dec 19, 2022
|
Thank you @alamirault. |
47eafe9 to
35890e1
Compare
|
@alamirault Thank you for working on this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime Yaml keys must be always string. (OpenApi spec for example)
This PR add support to dump int as string by using the
Yaml::DUMP_NUMERIC_KEY_AS_STRINGflag.Without flag (default)
With flag
(Unrelated fabbot failure)