Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Add env and param parameters for Autowire attribute #48147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2022
Merged

[DependencyInjection] Add env and param parameters for Autowire attribute #48147

merged 1 commit into from
Nov 26, 2022

Conversation

alexndlm
Copy link
Contributor

@alexndlm alexndlm commented Nov 8, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

These parameters will help not to miss % when auto-wiring the env variable or parameter.

@carsonbot carsonbot added this to the 6.2 milestone Nov 8, 2022
nicolas-grekas
nicolas-grekas reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@nicolas-grekas
Copy link
Member

Oh, can you please add some tests?

@alexndlm
Copy link
Contributor Author

alexndlm commented Nov 8, 2022

Oh, can you please add some tests?

Done

nicolas-grekas
nicolas-grekas approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for 6.2

@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 9, 2022
@fabpot fabpot force-pushed the feature/dependency-injection-add-env-and-param-to-Autowire-attribute branch from f497573 to ed94fdc Compare November 26, 2022 09:23
@fabpot
Copy link
Member

fabpot commented Nov 26, 2022

Thank you @alexndlm.

@fabpot fabpot mentioned this pull request Nov 26, 2022
Closed
@fabpot fabpot merged commit fd855dd into symfony:6.3 Nov 26, 2022
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@alexndlm @nicolas-grekas @fabpot @maxbeckers @carsonbot