Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Add encoder option for saving options #48164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

[Serializer] Add encoder option for saving options #48164

merged 1 commit into from
Dec 9, 2022

Conversation

ihmels
Copy link
Contributor

@ihmels ihmels commented Nov 8, 2022 •
edited
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR symfony/symfony-docs#17418

This changes add a new SAVE_OPTIONS to XmlEncoder. This new option is the counterpart to the LOAD_OPTIONS.

@ihmels ihmels requested a review from dunglas as a code owner November 8, 2022 21:04
@carsonbot carsonbot added this to the 6.2 milestone Nov 8, 2022
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@ihmels ihmels mentioned this pull request Nov 8, 2022
Merged
@ihmels ihmels force-pushed the xml-encoder-save-options branch from b4f46e4 to 385ea43 Compare November 8, 2022 21:24
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 9, 2022
@carsonbot carsonbot changed the title Add encoder option for saving options [Serializer] Add encoder option for saving options Nov 9, 2022
@ihmels ihmels force-pushed the xml-encoder-save-options branch from 385ea43 to f95f1f9 Compare November 9, 2022 19:05
@fabpot
Copy link
Member

fabpot commented Dec 9, 2022

Thank you @ihmels.

@fabpot fabpot merged commit 0c465c5 into symfony:6.3 Dec 9, 2022
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Dec 9, 2022
@OskarStark
feature #17418 Document save_options of XmlEncoder (ihmels)
ab95d44 
This PR was merged into the 6.3 branch.

Discussion
----------

Document `save_options` of `XmlEncoder`

Document new option added in symfony/symfony#48164.

Commits
-------

0df7bb1 Document `save_options` of `XmlEncoder` (symfony#48164)
@ihmels ihmels deleted the xml-encoder-save-options branch January 30, 2023 22:05
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Feature Serializer Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ihmels @carsonbot @fabpot @nicolas-grekas