Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Add {{pattern}} to Regex constraint violations #48232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Nov 17, 2022

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs/pull/17436

This PR add parameter pattern to Regex constraints violations.
This is useful for building message to technical users/consumers. (like limit, choices, min, max ... in other constraints )

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@OskarStark OskarStark changed the title [Validator] Add pattern in Regex constraint violations [Validator] Add {{pattern}} to Regex constraint violations Nov 18, 2022
@xabbuh xabbuh modified the milestones: 6.2, 6.3 Nov 18, 2022
@fabpot fabpot force-pushed the feature/regex-pattern-violation branch from 88fab25 to 369b051 Compare December 9, 2022 07:44
@fabpot
Copy link
Member

fabpot commented Dec 9, 2022

Thank you @alamirault.

@fabpot fabpot merged commit 96993d9 into symfony:6.3 Dec 9, 2022
@alamirault alamirault deleted the feature/regex-pattern-violation branch December 9, 2022 07:54
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Dec 9, 2022
…ions (alamirault)

This PR was merged into the 6.3 branch.

Discussion
----------

[Validator] Add `pattern` in `Regex` constraint violations

For 6.3

symfony/symfony#48232

Waiting Code merge (Is there a tip in order to set label at PR creation ?)

Commits
-------

db15323 [Validator] Add pattern in Regex constraint violations
@fabpot fabpot mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants