[Cache] Compatible with aliyun redis instance #48250
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.1". Cheers! Carsonbot |
|
Hey! I think @alamirault has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
looks like this PR is messed up (probably targetting a different branch than the one used to create your working branch), making the diff unreadable. |
Some cloud provider's redis instance is just compatible in common use command, but not some special command. Just like aliyun redis instance, doc: https://help.aliyun.com/document_detail/26342.html It based on redis protocol, but not really like the redis I know... I found that `$host->info('Memory')` will return false/null sometime, so and more safe check will be better for those special redis server.
c514ed4 to
9ab2435
Compare
|
Thank you @tourze. |
Some cloud provider's redis instance is just compatible in common use command, but not some special command. Just like aliyun redis instance, doc: https://help.aliyun.com/document_detail/26342.html It based on redis protocol, but not really like the redis I know...
I found that
$host->info('Memory')will return false/null sometime, so and more safe check will be better for those special redis server.