[Notifier] [Telegram] Add support to answer callback queries #48374

alexsoft · 2022-11-28T20:27:38Z

Q	A
Branch?	6.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix #47213
License	MIT
Doc PR	-

Example

$options = new TelegramOptions();
$options->answerCallbackQuery('123456', $showAlert = true, $cacheTime = 1);

$chatMessage->options($options);

I've intentionally omitted url parameter as that would only work in case of game which does not fit into notifier use case.
Telegram Bot Api doc for answerCallbackQuery - https://core.telegram.org/bots/api#answercallbackquery

carsonbot · 2022-11-28T20:27:40Z

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

carsonbot · 2022-11-28T20:29:59Z

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (see https://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

src/Symfony/Component/Notifier/Bridge/Telegram/CHANGELOG.md

src/Symfony/Component/Notifier/Bridge/Telegram/TelegramOptions.php

src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramOptionsTest.php

OskarStark

Thanks for your first contribution 🎉

alexsoft · 2022-11-30T20:30:48Z

Should I squash commits?

OskarStark · 2022-12-04T21:06:18Z

Thanks for your work on this new feature!

OskarStark · 2022-12-04T21:07:16Z

Should I squash commits?

I squashed them while merging.

Can you please open a PR in the symfony-docs repo about the new feature? Thank you

symfony/symfony-docs#1750

alexsoft force-pushed the telegram-answer-callback-query branch from a680016 to f4ee6aa Compare November 28, 2022 20:29

alexsoft marked this pull request as ready for review November 28, 2022 20:29

alexsoft requested a review from OskarStark as a code owner November 28, 2022 20:29

carsonbot added Status: Needs Review Feature Notifier labels Nov 28, 2022

carsonbot added this to the 6.3 milestone Nov 28, 2022

alexsoft force-pushed the telegram-answer-callback-query branch 2 times, most recently from 486b417 to 6134571 Compare November 28, 2022 20:50