Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Set manipulated message from event to original message #48393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Mailer] Set manipulated message from event to original message #48393

wants to merge 1 commit into from

Conversation

y4roc
Copy link

@y4roc y4roc commented Nov 29, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48221
License MIT

Set manipulated message from event to original message.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.0, 6.1, 6.2, 6.3.

Cheers!

Carsonbot

@y4roc y4roc changed the base branch from 4.4 to 5.4 November 29, 2022 16:04
@derrabus derrabus modified the milestones: 4.4, 5.4 Nov 29, 2022
@y4roc y4roc changed the title Issue 48221 [Mailer] Set manipulated message from event to original message Nov 29, 2022
@y4roc y4roc changed the base branch from 5.4 to 4.4 November 29, 2022 16:21
@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2022

Hasn't this been already fixed by #47822?

@y4roc
Copy link
Author

y4roc commented Nov 30, 2022

Yes, this has been already fixed.

@y4roc y4roc closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants