Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Add Termii bridge #48398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

[Notifier] Add Termii bridge #48398

merged 1 commit into from
Dec 2, 2022

Conversation

gnito-org
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#17486
Recipe symfony/recipes#1156

This PR add the Termii Notifier bridge.

@carsonbot carsonbot added this to the 6.3 milestone Nov 29, 2022
@gnito-org gnito-org force-pushed the termii-notifier branch 2 times, most recently from 145a2aa to 788c74e Compare November 29, 2022 22:43
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments

@OskarStark
Copy link
Contributor

Regarding fabbot:
CleanShot 2022-11-30 at 17 04 02@2x

(1) and (2) are false positives, the other ones can be applied

@gnito-org
Copy link
Contributor Author

I must be half-blind. Where do I see / access that fabbot report?

Screenshot

@OskarStark
Copy link
Contributor

I must be half-blind. Where do I see / access that fabbot report?

CleanShot 2022-11-30 at 20 15 38@2x

You need to scroll inline

@gnito-org
Copy link
Contributor Author

My bad that I didn't see the big MORE button and wide scroll bars.

@fabpot
Copy link
Member

fabpot commented Dec 2, 2022

Thank you @gnito-org.

@fabpot fabpot merged commit a855734 into symfony:6.3 Dec 2, 2022
@gnito-org gnito-org deleted the termii-notifier branch December 3, 2022 00:38
@fabpot fabpot mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants