Hi @y4roc, do you have time to handle the request change ? I'm really interested by this feature. :)

@VincentLanglet Feel free to take over if you have time to finish this PR.

@VincentLanglet Feel free to take over if you have time to finish this PR.

Hi @fabpot, sure I'll be happy to do it.
But I took a new look and what is missing in this PR ?

I think your review (#48409 (comment)) is incorrect, since the method need to return a SentMessage so we need to add the check

if ($event->isRejected()) {

after the line

$sentMessage = new SentMessage($message, $envelope);

@VincentLanglet Feel free to take over if you have time to finish this PR.

Hi @fabpot, sure I'll be happy to do it. But I took a new look and what is missing in this PR ?

I think your review (#48409 (comment)) is incorrect, since the method need to return a SentMessage so we need to add the check

if ($event->isRejected()) {

after the line

$sentMessage = new SentMessage($message, $envelope);

You're right, so we are only missing some tests.

@VincentLanglet I'm going to take over.

Should rejecting the mail stop the propagation of the MessageEvent? Currently, it doesn't and I thought we should at least have talked about it.

Should rejecting the mail stop the propagation of the MessageEvent? Currently, it doesn't and I thought we should at least have talked about it.

That's a good question. My take here is that you might have another listener interested in knowing the fact that the email has been rejected. It looks more flexible that way.

Right, but that listener would need to operate on a lower priority than any listener that might potentially reject messages. 🤔

Does rejecting the mail trigger a FailedMessageEvent?

• If yes, I'd probably attach my listener there or I might already have one here.
• If no: should it?

I would not trigger a FailedMessageEvent as the message didn't fail, it was just rejected from being sent.

As you don't necessarily know all listeners that can be registered in advance, maybe stopping the propagation is the more flexible way after all :) I've added another commit for that change. Let me know what you think.

I would let the listener do the logging when it makes sense. I tend to avoid logging whenever possible.

Thank you @y4roc.