Refactored the makePathRelative function #4842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Jul 11, 2012
Commits ------- 6def8d1 Refactored Filesystem::makePathRelative function to correctly handle more use-cases Discussion ---------- Refactored the makePathRelative function The function was failing in a number of different use cases because the function was incorrectly using a character offset comparison to determine where the common path stops. I've fixed this by splitting up the paths into their individual directories and then comparing the directory names. If the paths match then the function will return `./` and not an empty string. This is for consistency sake, to ensure all returned paths end with `/`.
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was failing in a number of different use cases because the function was incorrectly using a character offset comparison to determine where the common path stops.
I've fixed this by splitting up the paths into their individual directories and then comparing the directory names.
If the paths match then the function will return
./and not an empty string. This is for consistency sake, to ensure all returned paths end with/.