Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Add LINE Notify bridge #48466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2022
Merged

[Notifier] Add LINE Notify bridge #48466

merged 1 commit into from
Dec 4, 2022

Conversation

kurozumi
Copy link
Contributor

@kurozumi kurozumi commented Dec 4, 2022

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Add LINE Notifier Bridge.

LINE is one of the popular chat tools in Japan.
This bridge allows sending messages to LINE via LINE Notify.

@kurozumi kurozumi requested a review from OskarStark as a code owner December 4, 2022 02:18
@carsonbot carsonbot added this to the 6.3 milestone Dec 4, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

OskarStark
OskarStark reviewed Dec 4, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new bridge, I left some comments

@kurozumi
Copy link
Contributor Author

kurozumi commented Dec 4, 2022

@OskarStark Thank you, I applied those suggestions.

OskarStark
OskarStark reviewed Dec 4, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust UnsupportedSchemeException class

@kurozumi
Copy link
Contributor Author

kurozumi commented Dec 4, 2022

Fixed.

@OskarStark OskarStark changed the title Add LINE Notifier Bridge [Notifier] Add Line bridge Dec 4, 2022
@OskarStark OskarStark force-pushed the add-line-notify-notifier branch from a7b4e40 to e96524a Compare December 4, 2022 20:52
@OskarStark
Copy link
Contributor

Thank you @kurozumi.

@OskarStark OskarStark merged commit 945da85 into symfony:6.3 Dec 4, 2022
@OskarStark OskarStark mentioned this pull request Dec 4, 2022
Closed
@OskarStark OskarStark changed the title [Notifier] Add Line bridge [Notifier] Add Line Notify bridge Dec 4, 2022
@OskarStark OskarStark changed the title [Notifier] Add Line Notify bridge [Notifier] Add LINE Notify bridge Dec 4, 2022
@OskarStark OskarStark mentioned this pull request Dec 4, 2022
Merged
@kurozumi kurozumi deleted the add-line-notify-notifier branch December 5, 2022 04:49
@OskarStark OskarStark mentioned this pull request Dec 5, 2022
Merged
OskarStark added a commit that referenced this pull request Dec 5, 2022
@OskarStark
minor #48477 [Notifier] [Line] Fix tests (OskarStark)
4785cc7 
This PR was merged into the 6.3 branch.

Discussion
----------

[Notifier] [Line] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Follows
* #48466

cc `@kurozumi`

Commits
-------

9a87852 [Notifier][Line] Fix tests
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
This was referenced Oct 7, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kurozumi @carsonbot @OskarStark