[ProxyManagerBridge] Deprecate the package #48484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00ba39c to
61eea9c
Compare
fabpot
approved these changes
Dec 6, 2022
|
Can you have a look at the tests? fabbot is telling you something as well, not sure what. |
61eea9c to
52b6fa7
Compare
|
Tests fixed (failures unrelated, they will be fixed once merged up + let's skip fabbot on this one.) |
|
Thank you @nicolas-grekas. |
Merged
fabpot
added a commit
that referenced
this pull request
Jun 9, 2023
This PR was merged into the 7.0 branch. Discussion ---------- [ProxyManagerBridge] Drop the bridge | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As planned in #48484 Commits ------- b484e4b [ProxyManagerBridge] Drop the bridge
xabbuh
added a commit
that referenced
this pull request
Jun 21, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Test reset with a true manager | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Now that [assertions were added to the `AbstractManagerRegistry`](doctrine/persistence#375), the `ManagerRegistryTest` must register instances of `ObjectManager` to avoid tests failing with ``` assert(): assert($service instanceof ObjectManager) failed ``` Changes mostly come from #48484 but the ProxyManager is still used on 5.4, so beware when merging this in 6.4. Commits ------- 79b03db [DoctrineBridge] Test reset with a true manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridge is not needed anymore, we provide lazy services out of the box since 6.2.