[Notifier] [FakeChat] Allow missing optional dependency #48565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features / 5.4, 6.0, 6.1, or 6.2 for bug fixes". Cheers! Carsonbot |
OskarStark
reviewed
Dec 9, 2022
OskarStark
reviewed
Dec 9, 2022
OskarStark
approved these changes
Dec 9, 2022
OskarStark
approved these changes
Dec 9, 2022
|
Can you please squash the 4 commits into one? Our tool is only able to do this if all commits are from the same author... 😞 Afterwards I will merge this PR. Thank you! |
bbb8d0b to
3f312b8
Compare
|
Thanks Benjamin for working on this feature, this is much appreciated. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly the same as in this PR: #48546
This allows the
FakeChatTransportFactoryto be used without providing an implementation ofMailerInterfaceorLoggerInterfaceif one of them is actually not required during runtime.I did not share any of the implementation now between both components. I could think of pulling out the Exception as well as Parts of the test to something like a
FakeTransportFactoryTestCasefor example. What do you think?