Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Shared private services becomes public after a public service is accessed #48591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2022
Merged

[DependencyInjection] Shared private services becomes public after a public service is accessed #48591

merged 1 commit into from
Dec 15, 2022

Conversation

alexpott
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR N/a

@carsonbot carsonbot added this to the 6.3 milestone Dec 10, 2022
@alexpott alexpott force-pushed the shared-private-service-becomes-public branch from 8cf2a2f to 00170e2 Compare December 10, 2022 11:15
@alexpott alexpott changed the base branch from 6.3 to 5.4 December 10, 2022 11:15
@carsonbot carsonbot changed the title Shared private services becomes public after a public service is accessed [DependencyInjection] Shared private services becomes public after a public service is accessed Dec 10, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 5.4 Dec 15, 2022
@symfony symfony deleted a comment from carsonbot Dec 15, 2022
@symfony symfony deleted a comment from carsonbot Dec 15, 2022
@nicolas-grekas nicolas-grekas force-pushed the shared-private-service-becomes-public branch from 134c3c2 to 7cfde66 Compare December 15, 2022 10:17
nicolas-grekas
nicolas-grekas previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I made some changes. Can you have a look and see if they make sense to you?
An important thing is that the private/public concern only applies to compiled containers.

@nicolas-grekas nicolas-grekas force-pushed the shared-private-service-becomes-public branch from 7cfde66 to ece0c89 Compare December 15, 2022 10:30
@nicolas-grekas nicolas-grekas force-pushed the shared-private-service-becomes-public branch from ece0c89 to 8437494 Compare December 15, 2022 10:33
nicolas-grekas
nicolas-grekas approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and now green)

@nicolas-grekas
Copy link
Member

Thank you @alexpott.

@nicolas-grekas nicolas-grekas merged commit 35ac2d1 into symfony:5.4 Dec 15, 2022
@fabpot fabpot mentioned this pull request Dec 16, 2022
Merged
This was referenced Dec 28, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alexpott @nicolas-grekas @derrabus @carsonbot