Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] GoogleChat CardsV1 is deprecated we must use cardsV2 instead #48616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

[Notifier] GoogleChat CardsV1 is deprecated we must use cardsV2 instead #48616

merged 1 commit into from
Dec 22, 2022

Conversation

daifma
Copy link
Contributor

@daifma daifma commented Dec 12, 2022 •
edited by OskarStark
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? yes
License MIT

Based on google developers api documentation.
https://developers.google.com/chat/api/reference/rest/v1/cards-v1
CardsV1 is deprecated we must use cardsV2 instead.

@daifma daifma requested a review from OskarStark as a code owner December 12, 2022 16:16
@carsonbot carsonbot added this to the 6.3 milestone Dec 12, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features / 5.4, 6.0, 6.1, or 6.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@daifma daifma changed the title CardsV1 is deprecated we must use cardsV2 instead. [Notifier] CardsV1 is deprecated we must use cardsV2 instead. Dec 12, 2022
@carsonbot carsonbot changed the title [Notifier] CardsV1 is deprecated we must use cardsV2 instead. CardsV1 is deprecated we must use cardsV2 instead. Dec 12, 2022
@derrabus derrabus added Notifier and removed Bug labels Dec 12, 2022
@carsonbot carsonbot changed the title CardsV1 is deprecated we must use cardsV2 instead. [Notifier] CardsV1 is deprecated we must use cardsV2 instead. Dec 12, 2022
derrabus
derrabus requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@daifma daifma force-pushed the patch-1 branch 2 times, most recently from 4e69574 to 1494f25 Compare December 16, 2022 10:09
@daifma daifma requested a review from OskarStark December 16, 2022 10:11
@daifma daifma force-pushed the patch-1 branch 2 times, most recently from 61fe05e to af80d06 Compare December 16, 2022 15:53
@daifma daifma requested review from OskarStark and removed request for nicolas-grekas December 17, 2022 10:53
@daifma @nicolas-grekas
CardsV1 is deprecated we must use cardsV2 instead.
86db505 
Based on google developers api documentation.
https://developers.google.com/chat/api/reference/rest/v1/cards-v1
CardsV1 is deprecated we must use cardsV2 instead.
@nicolas-grekas nicolas-grekas changed the title [Notifier] CardsV1 is deprecated we must use cardsV2 instead. [Notifier] GoogleChat CardsV1 is deprecated we must use cardsV2 instead Dec 22, 2022
@nicolas-grekas
Copy link
Member

Thank you @daifma.

@nicolas-grekas nicolas-grekas merged commit 8cc74f1 into symfony:6.3 Dec 22, 2022
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 22, 2022
Closed
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof requested changes

@derrabus derrabus derrabus requested changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Deprecation Feature Notifier Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
7 participants
@daifma @carsonbot @nicolas-grekas @fabpot @stof @OskarStark @derrabus