Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Rename service notifier.logger_notification_listener to notifier.notification_logger_listener #48678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

[FrameworkBundle] Rename service notifier.logger_notification_listener to notifier.notification_logger_listener #48678

merged 1 commit into from
Jan 9, 2023

Conversation

ker0x
Copy link
Contributor

@ker0x ker0x commented Dec 16, 2022

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Fix #48519
License MIT
Doc PR -

@carsonbot carsonbot added this to the 6.3 milestone Dec 16, 2022
@OskarStark OskarStark changed the title [FrameworkBundle] Rename service notifier.logger_notification_listener to notifier.notification_logger_listener [FrameworkBundle] Rename service notifier.logger_notification_listener to notifier.notification_logger_listener Dec 18, 2022
@ker0x ker0x force-pushed the issue-48519 branch 2 times, most recently from f09d8e5 to 278e1de Compare December 19, 2022 11:34
@nicolas-grekas
Copy link
Member

I'm moot here. Is this possibly used directly by anyone? If not can't we take a shortcut and change the name on 6.1?

@chalasr
Copy link
Member

chalasr commented Dec 22, 2022 •
edited
Loading

Is this possibly used directly by anyone?

Possibly some Container::get() in test cases yes, as it has been introduced before NotificationAssertionsTrait (5.2 vs 6.2). I think it's worth taking the smooth path

nicolas-grekas
nicolas-grekas reviewed Dec 22, 2022
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/NotificationTest.php Outdated
*/
public function testNotifierAssertion()
{
$this->expectDeprecation('Since symfony/framework-bundle 6.3: The "notifier.logger_notification_listener" service is deprecated, use "notifier.notification_logger_listener" instead.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A legacy test is one that should be removed in 7.0
Since that's not the case here, it means something is missing to not trigger the deprecation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to determine how to not trigger the depreciation, some help would be appreciated 😕!

@ker0x @nicolas-grekas
[FrameworkBundle] Rename service `notifier.logger_notification_listen…
fcbfbb1 
…er` to `notifier.notification_logger_listener`
@nicolas-grekas
Copy link
Member

Thank you @ker0x.

@nicolas-grekas nicolas-grekas merged commit 5a832f4 into symfony:6.3 Jan 9, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 9, 2023
Closed
@ker0x ker0x deleted the issue-48519 branch January 9, 2023 11:17
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Deprecation Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
6.3
4 participants
@ker0x @nicolas-grekas @chalasr @carsonbot