[DependencyInjection] Deprecate integer keys in "service_locator" config #48686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2022
GromNaN
reviewed
Dec 16, 2022
| return new ServiceLocatorArgument(AbstractConfigurator::processValue($values, true)); | ||
| $values = AbstractConfigurator::processValue($values, true); | ||
|
|
||
| if (isset($values[0])) { |
There was a problem hiding this comment.
We can use array_is_list to detect numerically indexed arrays. But for a more complete validation, all key needs to be strings.
There was a problem hiding this comment.
I see, it's a bit confusing. It's possible to mix strings and sequential integers and non-sequential integers. The only sequential integers from zero (or undefined keys) are deprecated and will be replaced with IDs.
I will try to improve the messages. However, I could use help.
GromNaN
reviewed
Dec 16, 2022
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
Outdated
Show resolved
Hide resolved
chalasr
reviewed
Dec 18, 2022
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
Outdated
Show resolved
Hide resolved
afac82d to
249b26d
Compare
chalasr
approved these changes
Dec 22, 2022
249b26d to
57c2365
Compare
|
Thank you @upyx. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 21, 2023
…pyx) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Remove not implemented behavior Currently numeric keys are used, but it will be deprecated and changed in 7.0. Deprecation: symfony/symfony#48686 New behavior: symfony/symfony#48653 Commits ------- a8770de [DependencyInjection] Remove not implemented behavior
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It deprecates undefined/wrong behaviour of https://symfony.com/doc/current/service_container/service_subscribers_locators.html#defining-a-service-locator