Use static methods inside data providers #48709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "5.4". Cheers! Carsonbot |
OskarStark
commented
Dec 20, 2022
| $container->expects($this->exactly(2))->method('hasParameter')->willReturn(true); | ||
| $container->expects($this->exactly(2))->method('getParameter') | ||
| $container->expects(self::exactly(2))->method('hasParameter')->willReturn(true); | ||
| $container->expects(self::exactly(2))->method('getParameter') |
There was a problem hiding this comment.
All these methods are defined as static anyway, shall we fix them through the whole codebase starting from 5.4 @nicolas-grekas ? Automated via rector ofc
There was a problem hiding this comment.
No need to. That wouldn't provide any real added value but would consume a lot of time for sure.
OskarStark
commented
Dec 20, 2022
src/Symfony/Component/Finder/Tests/Iterator/SizeRangeFilterIteratorTest.php
Show resolved
Hide resolved
derrabus
reviewed
Dec 20, 2022
...ymfony/Component/DependencyInjection/Tests/Config/ContainerParametersResourceCheckerTest.php
Show resolved
Hide resolved
derrabus
requested changes
Dec 20, 2022
...ony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php
Show resolved
Hide resolved
...ony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php
Show resolved
Hide resolved
src/Symfony/Component/Finder/Tests/Iterator/SizeRangeFilterIteratorTest.php
Show resolved
Hide resolved
derrabus
approved these changes
Dec 20, 2022
|
RTM from my side as another partial one |
b9d6d46 to
9a18048
Compare
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #48668
follows