Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove calls to AnnotationRegistry::registerLoader() #48725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

Remove calls to AnnotationRegistry::registerLoader() #48725

merged 1 commit into from
Dec 22, 2022

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? yes
Tickets N/A
License MIT
Doc PR N/A

Calling AnnotationRegistry::registerLoader() should not be necessary anymore since Annotations 1.10 (April 2020), as long as all annotations are autoloadable. Let's remove all calls to that method.

@carsonbot carsonbot added this to the 6.3 milestone Dec 20, 2022
@derrabus
Copy link
Member Author

derrabus commented Dec 20, 2022 •
edited
Loading

Technically, we could do this on 5.4 already because AnnotationRegistry::registerLoader('class_exists'); should be a no-op and we already have conflict rules for Annotations < 1.10 in place. Let me know if you think I should backport the change.

The low-deps tests showed me that we should not backport. Registering class_exists as loader is still necessary, if someone somewhere calls (the also deprecated) AnnotationRegistry::registerFile(). Removing our only call to that method required me to bump the ORM to >= 2.12.

We cannot anticipate if a codebase still has that AnnotationRegistry::registerFile() call somewhere, so we might as well decide to not merge this change as long as we support Annotations v1.

@derrabus derrabus force-pushed the improvement/remove-annotation-loader branch from 28a7226 to caf16ed Compare December 20, 2022 19:54
@derrabus derrabus force-pushed the improvement/remove-annotation-loader branch from caf16ed to 066d851 Compare December 22, 2022 09:39
@nicolas-grekas nicolas-grekas force-pushed the improvement/remove-annotation-loader branch from 066d851 to c0e9ee1 Compare December 22, 2022 14:39
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 4586963 into symfony:6.3 Dec 22, 2022
@derrabus derrabus deleted the improvement/remove-annotation-loader branch December 22, 2022 14:40
@maxhelias maxhelias mentioned this pull request Dec 23, 2022
Merged
nicolas-grekas added a commit that referenced this pull request Dec 28, 2022
@nicolas-grekas
[PhpUnitBridge] Revert "minor #48725 Remove calls to `AnnotationRegis…
9f5c005 
…try::registerLoader()`"
@nicolas-grekas
Copy link
Member

I reverted the part about phpunit-bridge in 9f5c005

@derrabus
Copy link
Member Author

Fair enough, but the ORM bump in the root composer.json was still legit. Why did you revert it as well?

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 28, 2022 •
edited
Loading

By mistake, let me fix that.
Fixed in 6d3b3f1

@derrabus
Copy link
Member Author

Thanks!

@alexislefebvre alexislefebvre mentioned this pull request Jan 7, 2023
Closed
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Jan 9, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
9d664ba 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Jan 9, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
c66ecb9 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Jan 9, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
e0a7b80 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Jan 9, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
2655ecb 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Jan 9, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
52e6946 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Feb 15, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
555e7f8 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Feb 15, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
47138d9 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Feb 15, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
6cd8b6e 
…onRegistry::registerLoader()`"
bitgandtter pushed a commit to timgchile/symfony that referenced this pull request Feb 15, 2023
@nicolas-grekas @bitgandtter
[PhpUnitBridge] Revert "minor symfony#48725 Remove calls to `Annotati…
f7165d7 
…onRegistry::registerLoader()`"
This was referenced Jun 13, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @nicolas-grekas @stof @carsonbot