Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ExpressionLanguage] Fix GetAttrNode export with all versions of VarExporter #48734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ExpressionLanguage] Fix GetAttrNode export with all versions of VarExporter #48734

wants to merge 1 commit into from

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets #48706
License MIT
Doc PR -

Adding __serialize fixes the bug and avoid us to add conflict rules.

@carsonbot carsonbot added this to the 6.2 milestone Dec 21, 2022
@nicolas-grekas
Copy link
Member

We'd better not do this IMHO. This can break when eg __sleep is implemented.
Upgrading VarExporter will provide the fix, that's enough to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug ExpressionLanguage Status: Needs Review
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot