Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Cut compilation time #48802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

[DependencyInjection] Cut compilation time #48802

merged 1 commit into from
Dec 28, 2022

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 28, 2022 •
edited
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Two more victories for Blackfire.io 🎉

First win for InlineServiceDefinitionsPass: -58%

image

Second win for ContainerBuilder::inVendors(): an additional -6.5%

image

Confirmed -50% without Blackfire also: from 30s to 15s.

@carsonbot carsonbot added this to the 6.3 milestone Dec 28, 2022
chalasr
chalasr approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@tucksaun
Copy link
Contributor

👏

@fabpot
Copy link
Member

fabpot commented Dec 28, 2022

Thank you @nicolas-grekas.

@fabpot fabpot mentioned this pull request Dec 28, 2022
Closed
@fabpot fabpot merged commit f3fc6d7 into symfony:6.3 Dec 28, 2022
@nicolas-grekas nicolas-grekas deleted the di-perf branch December 28, 2022 13:47
@dunglas
Copy link
Member

dunglas commented Dec 28, 2022

Waouh⚡️

@nicolas-grekas nicolas-grekas mentioned this pull request Jan 27, 2023
Closed
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
@MatTheCat MatTheCat mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
DependencyInjection Performance Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
7 participants
@nicolas-grekas @tucksaun @fabpot @dunglas @chalasr @javiereguiluz @carsonbot