Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] remove double required annotation + attribute #48874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2023
Merged

[FrameworkBundle] remove double required annotation + attribute #48874

merged 1 commit into from
Jan 7, 2023

Conversation

alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Jan 5, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48792 (checked with this reproducer)
License MIT
Doc PR no

Annotation and attribute were kept: #45680 (comment)

To my understanding, it's not necessary since #48810

Alternative to #48868

@carsonbot carsonbot added this to the 6.3 milestone Jan 5, 2023
@alexislefebvre alexislefebvre changed the title remove double required annotation + attribute [FrameworkBundle] remove double required annotation + attribute Jan 5, 2023
@alexislefebvre alexislefebvre mentioned this pull request Jan 6, 2023
Closed
@carsonbot carsonbot changed the title [FrameworkBundle] remove double required annotation + attribute remove double required annotation + attribute Jan 6, 2023
@carsonbot carsonbot changed the title remove double required annotation + attribute [FrameworkBundle] remove double required annotation + attribute Jan 6, 2023
nicolas-grekas
nicolas-grekas approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should not forget to also fix doctrine's part.

@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Jan 7, 2023 •
edited
Loading

Yes there will be still an issue for users of Symfony 6.2.

@fabpot
Copy link
Member

fabpot commented Jan 7, 2023

Thank you @alexislefebvre.

@fabpot fabpot merged commit 0622750 into symfony:6.3 Jan 7, 2023
@alexislefebvre alexislefebvre deleted the 6.3-remove-double-required-annotation branch January 7, 2023 17:07
@alexislefebvre alexislefebvre mentioned this pull request Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

Annotation @required causing issue after migrating from 6.0 to 6.1
6 participants
@alexislefebvre @fabpot @nicolas-grekas @stof @derrabus @carsonbot