Fix ParameterBagTest message with PHP 8.2 #48902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c00a765 to
b003136
Compare
OskarStark
approved these changes
Jan 7, 2023
OskarStark
reviewed
Jan 7, 2023
| @@ -242,7 +242,11 @@ public function testGetEnumThrowsExceptionWithNotBackingValue() | |||
| $bag = new ParameterBag(['invalid-value' => 2]); | |||
|
|
|||
| $this->expectException(\UnexpectedValueException::class); | |||
| $this->expectExceptionMessage('Parameter "invalid-value" cannot be converted to enum: 2 is not a valid backing value for enum "Symfony\Component\HttpFoundation\Tests\Foo".'); | |||
| if (\PHP_VERSION_ID >= 80200) { | |||
There was a problem hiding this comment.
This file change must target a lower branch, 6.0 imho
There was a problem hiding this comment.
As @MatTheCat mentioned, the bug was added by #48820 in 6.3
And yes, he has found another issue with enums.
b536fdc to
0802dff
Compare
fabpot
approved these changes
Jan 7, 2023
|
Thank you @upyx. |
fabpot
added a commit
that referenced
this pull request
Jan 7, 2023
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- Fix ParameterBagTest message with PHP 8.2 | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | nope | License | MIT | Doc PR | nope Checking every time that tests failed just because of that minor thing makes me angry. Commits ------- 809f02c Fix ParameterBagTest message with PHP 8.2
0802dff to
809f02c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking every time that tests failed just because of that minor thing makes me angry.