[DependencyInjection] fixes validation of non-scalar attribute values #48958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju1ius
commented
Jan 12, 2023
src/Symfony/Component/DependencyInjection/Compiler/CheckDefinitionValidityPass.php
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckDefinitionValidityPassTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Jan 12, 2023
60ea7f7 to
88b3e15
Compare
|
Thank you @ju1ius. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #47364, this PR updates the
CheckDefinitionValidityPassto allow (possibly nested) arrays of scalars in service tags attribute values.Please see #48956 for context.