[WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters #48963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 12, 2023
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
|
@stof thanks for the review! I've just updated everything. |
stof
reviewed
Jan 12, 2023
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
Outdated
Show resolved
Hide resolved
|
@stof I did all the suggested changes. Thanks a lot for your detailed review. Symfony project is so lucky to have you as an active reviewer of contributions! |
stof
approved these changes
Jan 13, 2023
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jan 14, 2023
…anel filters (javiereguiluz) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #48762 (comment) | License | MIT | Doc PR | - This only changes the HTML contents of the logger profiler panel to make them valid (and keeps them accessible). No feature or behavior was changed. Commits ------- a8523cb [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters
e918a77 to
a8523cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only changes the HTML contents of the logger profiler panel to make them valid (and keeps them accessible). No feature or behavior was changed.