Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PropertyInfo] Fixes constructor extractor for mixed type #48969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2023
Merged

[PropertyInfo] Fixes constructor extractor for mixed type #48969

merged 1 commit into from
Jan 14, 2023

Conversation

MichaelKubovic
Copy link

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

ConstructorExtractor when configured with PhpDocExtractor returns an empty array instead of null for properties with mixed type.

This configuration breaks for example with Messenger.

Message: "Could not decode stamp: The type of the "id" attribute for class "Symfony\Component\Messenger\Stamp\TransportMessageIdStamp" must be one of "" ("string" given)." {"exception":"[object] (Symfony\\Component\\Messenger\\Exception\\MessageDecodingFailedException(code: 0): Could not decode stamp: The type of the \"id\" attribute for class \"Symfony\\Component\\Messenger\\Stamp\\TransportMessageIdStamp\" must be one of \"\" (\"string\" given). at /var/www/vendor/symfony/messenger/Transport/Serialization/Serializer.php:123)

@carsonbot carsonbot added this to the 5.4 milestone Jan 12, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Fixes constructor extractor for mixed type [PropertyInfo] Fixes constructor extractor for mixed type Jan 12, 2023
@MichaelKubovic
Copy link
Author

All issues fixed.

@fabpot fabpot force-pushed the mixed-constructor branch from 6d2c6cc to 4edd347 Compare January 14, 2023 11:27
@fabpot
Copy link
Member

fabpot commented Jan 14, 2023

Thank you @MichaelKubovic.

@fabpot fabpot merged commit fe23f0f into symfony:5.4 Jan 14, 2023
This was referenced Jan 24, 2023
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelKubovic @carsonbot @fabpot @nicolas-grekas