[Tests] Remove $this occurrences in future static data providers
#48980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexandre-daubois
commented
Jan 14, 2023
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes-ish |
| New feature? | no |
| Deprecations? | no |
| Tickets | Easing #48668 (comment) |
| License | MIT |
| Doc PR | NA |
c0b9c73 to
99f3168
Compare
OskarStark
approved these changes
Jan 14, 2023
99f3168 to
6fb7cb9
Compare
|
Friendly ping @nicolas-grekas this is another PR on the road to static dataProviders. Thanks |
nicolas-grekas
approved these changes
Jan 15, 2023
fabpot
approved these changes
Jan 15, 2023
|
Thank you @alexandre-daubois. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 1, 2023
… future static data providers (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Tests] New iteration of removing `$this` occurrences in future static data providers | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes-ish | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Easing #48668 (comment) | License | MIT | Doc PR | _NA_ Follow-up of #48980 Commits ------- 1386ac2 [Tests] New iteration of removing `$this` occurrences in future static data providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.