[WebProfilerBundle] Mailer panel tweaks #48997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: it looks like this PR changes lots of lines, but it just reorders some HTML contents and changes some indentations, so the real changes are minimal
Currently, the email details only shows the bodies defined in the email. E.g. if some email has a text body and not an HTML body, you see this:
I think this doesn't look nice. I think it's better to always display text content + HTML content and display a message if some of them (or both) are empty.
This is how it'd look after this PR:
Email with text and HTML bodies
Email with text body and no HTML body
If you click on HTML tab:
Email with HTML body and no text body
Email without text and HTML bodies