The Symfony 5.4 version of MigratingSessionHandler does not use intersection types, so it does not suffer from this problem. No backport needed unless you run CI on a branch other than 5.4 or 6.3.

Given that Psalm v5 has support for intersection type, it would be better to migrate to psalm v5 in our CI.

Given that Psalm v5 has support for intersection type, it would be better to migrate to psalm v5 in our CI

We're already using Psalm v5, what makes you think that we aren't? See the @see link, I'm pretty sure this is an upstream bug in Psalm, not a general lack of support for intersection types.

Psalm does support intersection types, so this patch seems too generic to me. https://psalm.dev/r/1daf678918

The referenced bug talks about using build-in types in intersection types, which seems to be broken: https://psalm.dev/r/bea279b49e

what makes you think that we aren't?

What made me think that we aren't is the comment in the code saying "remove this when Psalm implements intersection types", while Psalm v5 has implemented them.

Ah I see what you mean, I'll update the comment to indicate that this is a Psalm bug and not a lack of support.

@wouterj are you saying you want to see a new Psalm bug opened?

Let me know what you want on this, it would really help contributors (and maintainers, I imagine!) to have all tests passing.

Sorry, I misread the changes (I thought it was doing a global find&replace instead of a local one in the file). Let's go 👍

(the Psalm bug you referenced is good enough, the maintainers are already on the case it seems and it is about the same issue)

Thank you @danepowell.