Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] Close profiler settings on escape #49011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

[WebProfilerBundle] Close profiler settings on escape #49011

merged 1 commit into from
Jan 19, 2023

Conversation

norkunas
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

This improves accessibility with the profiler settings, now when you open the modal you can also close it Escape.

@carsonbot carsonbot added this to the 6.3 milestone Jan 17, 2023
javiereguiluz
javiereguiluz approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Thanks Tomas.

@fabpot
Copy link
Member

fabpot commented Jan 19, 2023

Thank you @norkunas.

@fabpot fabpot mentioned this pull request Jan 19, 2023
Closed
@fabpot fabpot merged commit 66952fd into symfony:6.3 Jan 19, 2023
@norkunas norkunas deleted the escclose branch January 19, 2023 20:00
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@norkunas @fabpot @javiereguiluz @stof @carsonbot